Hi Tim,
(02-12-2014, 06:14 PM)Forums Wrote: I have seen windows/Linux/ and Mac servers with webERP setup and working for many years with upper case database names, so I am not convinced that it causes any issue on an OS level.
The bug I'm talking about has nothing to do with database name. The database name, as previously mentioned should be able to be upper or lower case and have special characters which Exson has confirmed, is the case.
Quote: It seems to me that if the user gets to this point in ConnectDB they must have a system that would work, so if a check is necessary this is the wrong place.
I would agree however it's not the way webERP has worked - ever since I've used it connectDB had a check of directory against database name. It's still there under the provision for 'old' setups. I just created a variant for the new secure database name check and logic if lowercase directory name is to be used. As mentioned, the bug in this logic, was not in connectdb but in the installer that should have setup a lower case company name directory.
Quote:2 We must not assume that the user will use the installer.
Of course, no need to say more.
As mentioned previously, just providing the logic behind the changes for the new installer and obfuscation of database name, and notifying of what the bug was related to that logic.
If the code works now and you're happy with it, keep the old logic in the code, which then points to a bug in connectDB that has been fixed fix applied.
Cheers,